Re: [PATCH 1/1] atmel-ssc: fix misuse of dev_dbg when requested sscinstance is not found

From: Hans-Christian Egtvedt
Date: Fri Jan 30 2009 - 03:20:57 EST


On Thu, 29 Jan 2009 15:50:42 -0800
Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Thu, 29 Jan 2009 17:46:55 +0100
> Hans-Christian Egtvedt <hans-christian.egtvedt@xxxxxxxxx> wrote:
>

<snipp>

> > Bump, or did I miss the merge window?
> >
>
> (Top-posting repaired. Please don't do that! It makes it horrid to
> reply to you)
>

Sorry, I'll do a resend of the original email instead next time. I had
the idea about the initial email would be picked up.

> (Suitable cc's added - this was why your patch got lost)
>

AFAICT the lkml is the place for the drivers/misc stuff. Should I be
looking in another file than MAINTAINERS?

> The patch seems reasonable but the changelog seems to be quite
> misleading. I did this:
>
> The ssc pointer is not valid when the id is not found in the
> list. Convert the message from a debug one into an error message
> and avoid dereferencing the bad pointer.
>
> OK?

Sounds way better than my Norwegian English, thanks (-:

--
Best regards,
Hans-Christian Egtvedt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/