Re: [PATCH 4 of 7] x86/paravirt: selectively save/restore regs around pvops calls

From: Rusty Russell
Date: Thu Jan 29 2009 - 19:27:52 EST


On Thursday 29 January 2009 20:00:34 Jeremy Fitzhardinge wrote:
> Rusty Russell wrote:
> > It's kind of messy. Can we do something clever here with token pasting?
>
> I tried a few things, but no. Passing in just RAX, and then pasting
> CLBR_##reg works, and the assembler accepts %RAX - but - the asm code
> also #defines RAX <some stack offset>, so the assembler ends up seeing
> %48. I considered renaming all the CLBR_ defines to CLBR_rax, but that
> looks unhappy too. So I stayed with this.

OK, then Acked-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx> on this one too.

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/