Re: [PATCH 1/1] atmel-ssc: fix misuse of dev_dbg when requested sscinstance is not found

From: Hans-Christian Egtvedt
Date: Thu Jan 29 2009 - 11:53:22 EST


On Mon, 19 Jan 2009 13:57:56 +0100
Hans-Christian Egtvedt <hans-christian.egtvedt@xxxxxxxxx> wrote:

Bump, or did I miss the merge window?

> This patch replaces the dev_dbg(...) with a pr_err since the ssc
> pointer is not valid when the id is not found in the list.
>
> Signed-off-by: Hans-Christian Egtvedt
> <hans-christian.egtvedt@xxxxxxxxx> ---
> drivers/misc/atmel-ssc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c
> index 6b35874..6cff1bb 100644
> --- a/drivers/misc/atmel-ssc.c
> +++ b/drivers/misc/atmel-ssc.c
> @@ -35,7 +35,7 @@ struct ssc_device *ssc_request(unsigned int ssc_num)
>
> if (!ssc_valid) {
> spin_unlock(&user_lock);
> - dev_dbg(&ssc->pdev->dev, "could not find requested device\n");
> + pr_err("ssc: ssc%d platform device is missing\n", ssc_num);
> return ERR_PTR(-ENODEV);
> }
>

--
Best regards,
Hans-Christian Egtvedt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/