[BUILD_FAILURE] 2.6.29-rc3 : drivers/ata/sata_sil.c

From: Sachin P. Sant
Date: Thu Jan 29 2009 - 04:28:46 EST


2.6.29-rc3 with allmodconfig breaks with following message


CALL arch/powerpc/kernel/systbl_chk.sh
CALL arch/powerpc/kernel/prom_init_check.sh
LD [M] drivers/ata/libata.o
CC [M] drivers/ata/sata_sil.o
drivers/ata/sata_sil.c: In function sil_broken_system_poweroff:
drivers/ata/sata_sil.c:713: error: implicit declaration of function dmi_first_match
drivers/ata/sata_sil.c:713: warning: initialization makes pointer from integer without a cast
make[2]: *** [drivers/ata/sata_sil.o] Error 1
make[1]: *** [drivers/ata] Error 2
make: *** [drivers] Error 2

Probably needs to include <linux/dmi.h>. The following patch fixes it.

Signed-off-by : Sachin Sant <sachinp@xxxxxxxxxx>

---


--

---------------------------------
Sachin Sant
IBM Linux Technology Center
India Systems and Technology Labs
Bangalore, India
---------------------------------

* Fix ata build break (undefined dmi_first_match symbol)

Signed-off-by : Sachin Sant<sachinp@xxxxxxxxxx>
---

diff -Naurp a/drivers/ata/sata_sil.c b/drivers/ata/sata_sil.c
--- a/drivers/ata/sata_sil.c 2009-01-29 00:19:30.000000000 +0530
+++ b/drivers/ata/sata_sil.c 2009-01-29 17:15:03.000000000 +0530
@@ -44,6 +44,7 @@
#include <linux/device.h>
#include <scsi/scsi_host.h>
#include <linux/libata.h>
+#include <linux/dmi.h>

#define DRV_NAME "sata_sil"
#define DRV_VERSION "2.4"