Re: [PATCH RFC WIP] x86/paravirt: add register-saving thunks to reducecaller register pressure

From: Jeremy Fitzhardinge
Date: Wed Jan 28 2009 - 18:17:37 EST


Zachary Amsden wrote:
Standard calling convention is:
arguments return scratch
x86-32 eax edx ecx eax ?

ecx, edx

OK, no scratch beyond the arg regs.

XXX Deal with VMI. What's their calling convention?

Enable/Disable have no clobbers at all.
Save clobbers only return value, %eax
Restore also clobbers nothing.

OK, they can be plugged in directly then. Use __PV_IS_CALLEE_SAVE(func) to wrap it up in the right type.

The patching code has gotten quite complex with the 32/64 union; let me
apply it first and see before I comment on the patch.

OK. I just posted updated versions of this series, so make sure you comment on that one.

J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/