Re: [PATCH] migration: migrate_vmas should check "vma"

From: Johannes Weiner
Date: Wed Jan 28 2009 - 11:55:47 EST


On Wed, Jan 28, 2009 at 11:42:36AM -0500, Christoph Lameter wrote:
> On Wed, 28 Jan 2009, Daisuke Nishimura wrote:
>
> > migrate_vmas() should check "vma" not "vma->vm_next" for for-loop condition.
>
> The loop condition is checked before vma = vma->vm_next. So the last
> iteration of the loop will now be run with vma = NULL?

No, the condition is always checked before the body is executed. The
assignment to vma->vm_next happens at the end of every body.

Try this:

int a = 2;

for (puts("init"); puts("cond"), a; puts("next"))
a--;

Hannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/