Re: [PATCH 05/10] omap mailbox: fix empty struct device for omap1
From: Hiroshi DOYU
Date: Wed Jan 28 2009 - 10:34:33 EST
Hi Russell,
From: ext Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx>
Subject: Re: [PATCH 05/10] omap mailbox: fix empty struct device for omap1
Date: Wed, 28 Jan 2009 15:49:55 +0100
> On Fri, Jan 16, 2009 at 10:27:27AM +0200, Hiroshi DOYU wrote:
> > @@ -17,6 +17,8 @@
> > #include <mach/mailbox.h>
> > #include <mach/irqs.h>
> >
> > +#define DRV_NAME "omap1-mailbox"
>
> I don't see any need for this define - it just adds an additional level of
> indirection when trying to find out the name of the driver. It's only
> used in two places as is, so it's value is rather limited:
I fixed this along with the patch 06/10 as well. A whole patchset is available as:
The following changes since commit 1de9e8e70f5acc441550ca75433563d91b269bbe:
Linus Torvalds (1):
Linux 2.6.29-rc2
are available in the git repository at:
http://git.gitorious.org/lk/mainline.git mailbox
Hiroshi DOYU (10):
omap mailbox: cleanup omap2 register definition with macro
omap mailbox: add initial omap3 support
omap mailbox: print hardware revision at startup
omap mailbox: fix empty struct device for omap_mbox
omap mailbox: fix empty struct device for omap1
omap mailbox: fix empty struct device for omap2
omap mailbox: add save_/restore_ctx() for PM
omap mailbox: move mailbox.h into mailbox.c
omap mailbox: convert sequence bit checking to module paramter
omap mailbox: remove unnecessary header file inclusion
arch/arm/mach-omap1/devices.c | 2 +-
arch/arm/mach-omap1/mailbox.c | 33 +++--
arch/arm/mach-omap2/devices.c | 39 ++++--
arch/arm/mach-omap2/mailbox.c | 199 ++++++++++++++++------------
arch/arm/plat-omap/Kconfig | 8 +
arch/arm/plat-omap/include/mach/mailbox.h | 27 ++++-
arch/arm/plat-omap/include/mach/omap34xx.h | 1 +
arch/arm/plat-omap/mailbox.c | 152 ++++++++++++++++------
arch/arm/plat-omap/mailbox.h | 100 --------------
9 files changed, 313 insertions(+), 248 deletions(-)
delete mode 100644 arch/arm/plat-omap/mailbox.h