Re: [PATCH -mmotm] mm: unify some pmd_*() functions

From: Andrew Morton
Date: Tue Jan 27 2009 - 20:42:49 EST


On Sun, 25 Jan 2009 22:35:37 +0100
Andrea Righi <righi.andrea@xxxxxxxxx> wrote:

> diff --git a/include/asm-generic/pgtable-nopmd.h b/include/asm-generic/pgtable-nopmd.h
> index a7cdc48..b132d69 100644
> --- a/include/asm-generic/pgtable-nopmd.h
> +++ b/include/asm-generic/pgtable-nopmd.h
> @@ -4,6 +4,7 @@
> #ifndef __ASSEMBLY__
>
> #include <asm-generic/pgtable-nopud.h>
> +#include <asm/bug.h>
>
> struct mm_struct;
>

Why not include the preferred <linux/bug.h>?

> BTW, I only tested this on x86 and x86_64. This needs more testing because it
> touches also a lot of other architectures.

Hopefully Geert, Roman, David and Hirokazu Takata will have time to
help out here.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/