Re: [git patches] libata fixes

[Tejun Heo]

Hello, Linus, Jeff.

Linus Torvalds wrote:
> 
> On Tue, 27 Jan 2009, Jeff Garzik wrote:
>> I also habitually _avoid_ "git commit -a", so I am surprised that I actually
>> made this mistake.  I am 100% certain that I issued neither "git rm" nor "git
>> update-index" commands on that file.
>>
>> Granted, I should have been more careful, but I am also surprised this
>> happened at all.
> 
> Well, it's attributed to Tejun, and he probably sent you a "git diff". The 
> delete part of such a diff is pretty small, so you both probably missed 
> it at the top of the diff:
> 
> 	diff --git a/arch/arm/mach-integrator/clock.h b/arch/arm/mach-integrator/clock.h
> 	deleted file mode 100644
> 	index e69de29..0000000
> 
> and then you used "git am -s" or something to apply it and delete that 
> file.
> 
> No "git commit -a" necessary - just a simple "git diff" after having done 
> a "make distclean" and then sending the result off by email without 
> looking any closer..

Yes, that patch was generated with "git diff" and distclean was done
cuz I just began to use separate output directories for build.  I've
restored the empty file for several times for other patches but it
slipped this time.  My apologies.  I'll be more careful.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/