Re: [PATCH 1/1] mmc: add MODALIAS linkage for MMC/SD devices

From: Pierre Ossman
Date: Tue Jan 27 2009 - 14:14:24 EST


On Sun, 25 Jan 2009 17:00:11 +0100
Kay Sievers <kay.sievers@xxxxxxxx> wrote:

> On Sun, Jan 25, 2009 at 16:48, Pierre Ossman <drzeus-mmc@xxxxxxxxx> wrote:
> >
> > My point was to have the kernel explicitly ask for the module it wants
> > as there is no decent device to driver mapping scheme.
>
> Yep, which is what we do not want. Aliases are "aliases", and not
> "module names". We need to add a matching alias to the module then.
> Direct module names can not properly defined/blacklisted in userspace,
> and we would need to work around that.
> Every modalias should be
> "<subsystem>:<whatever-name-fits-for-the-subsystem>" to plug properly
> into the autoloading infrastructure. We rather have no modalias at
> all, then a kernel module name there.
>

The thing is that asking for a module is the only thing we can do here.
We can dress it up and give it some special coding to not cause
problems, but the code will always be "ask userspace to load
mmc_block", even if we replace "mmc_block" with "mmc:foobargazonk".

Given that, do you have any preferences for a solution? If we cannot
simply have "mmc_block", then I'm leaning to "mmc:block" for now. The
contents of the aliases is just an opaque string as far as userspace is
concerned, right?

Rgds
--
-- Pierre Ossman

Linux kernel, MMC maintainer http://www.kernel.org
rdesktop, core developer http://www.rdesktop.org

WARNING: This correspondence is being monitored by the
Swedish government. Make sure your server uses encryption
for SMTP traffic and consider using PGP for end-to-end
encryption.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/