RE: [PATCH -tip] IA64: fix the compile error on IA64_DIG_VTD

From: Luck, Tony
Date: Tue Jan 27 2009 - 12:18:33 EST


> > > ---
> > > arch/ia64/kernel/dma-mapping.c | 3 +++
> > > arch/ia64/kernel/pci-swiotlb.c | 3 ---
> > > 2 files changed, 3 insertions(+), 3 deletions(-)
> >
> > Applied to tip/core/iommu, thanks!
>
> Tony, is this fix fine with you too?

It works ... and dma-mapping.c is OK as a location for the
definition. But there seemes to be some small scope for a
related cleanup:

There are "extern" declarations for "iommu_detected" in both
<asm/iommu.h> (x86 and ia64) and also in <linux/dmar.h>

Does having both of these avoid some #include hell?

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/