Re: [PATCH] module: kzalloc mod->ref

[Ingo Molnar]

* Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:

> @@ -344,8 +339,11 @@ struct module
>  	/* Destruction function. */
>  	void (*exit)(void);
>  
> -	/* Reference counts */
> -	struct module_ref ref[NR_CPUS];
> +#ifdef CONFIG_SMP
> +	char *refptr;
> +#else
> +	local_t ref;
> +#endif

hm, that construct looks rather ugly. Is there no way to provide a clean 
data type and APIs for this that just work symmetrically on both SMP and 
UP?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/