Re: devpts multiple instances feedback

From: Sukadev Bhattiprolu
Date: Mon Jan 26 2009 - 22:36:20 EST


Christoph Hellwig [hch@xxxxxx] wrote:
| On Sat, Jan 03, 2009 at 05:15:44PM +0100, Christoph Hellwig wrote:
| > This is a little untested patch to massage the mount code into about
| > how it should look like:
|
| ping?

I was waiting for discussion on the other thread. But yes, this does
simplify the code by copying in the common code in get_sb_single() and
get_sb_nodev() into devpts, and eliminating the do_remount() stuff in
'single-mount' mode.

We may also be able to define an "empty" mknod_ptmx() when
CONFIG_DEVPTS_MULTIPLE_INSTANCES=n and share a bit more code, but will
defer that to a separate patch.

Will test this out some more and resend the modified patch.

Sukadev
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/