Re: [PATCH 1/2] x86: optimize a bit __raw_read_trylock

[Ingo Molnar]

* Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:

> The current version of __raw_read_trylock starts with decrementing the lock
> and read its new value as a separate operation after that.
> 
> That makes 3 dereferences (read, write (after sub), read) whereas
> a single atomic_dec_return does only two pointers dereferences (read, write).
> 
> Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> ---
>  arch/x86/include/asm/spinlock.h |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/include/asm/spinlock.h b/arch/x86/include/asm/spinlock.h
> index 2bd6b11..139b424 100644
> --- a/arch/x86/include/asm/spinlock.h
> +++ b/arch/x86/include/asm/spinlock.h
> @@ -267,8 +267,7 @@ static inline int __raw_read_trylock(raw_rwlock_t *lock)
>  {
>  	atomic_t *count = (atomic_t *)lock;
>  
> -	atomic_dec(count);
> -	if (atomic_read(count) >= 0)
> +	if (atomic_dec_return(count) >= 0)
>  		return 1;
>  	atomic_inc(count);
>  	return 0;

nice one ... applied it to tip/x86/asm, thanks Frederic!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/