Re: [Linux 2.6.29-rc2] BUG: using smp_processor_id() in preemptible

From: Maciej Rutecki
Date: Sun Jan 25 2009 - 11:31:18 EST


2009/1/25 Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>:
[...]
>
>
> Does this fix it?

Yes, message has gone. Thanks for help.

Tested-by Maciej Rutecki <maciej.rutecki@xxxxxxxxx>
>
> --- a/kernel/hrtimer.c~a
> +++ a/kernel/hrtimer.c
> @@ -562,7 +562,7 @@ static int hrtimer_reprogram(struct hrti
> /*
> * Retrigger next event is called after clock was set
> *
> - * Called with interrupts disabled via on_each_cpu()
> + * Called with interrupts disabled.
> */
> static void retrigger_next_event(void *arg)
> {
> @@ -614,8 +614,12 @@ void clock_was_set(void)
> */
> void hres_timers_resume(void)
> {
> + unsigned long flags;
> +
> /* Retrigger the CPU local events: */
> + local_irq_save(flags);
> retrigger_next_event(NULL);
> + local_irq_restore(flags);
> }
>
> /*
> _
>
>



--
Maciej Rutecki
http://www.maciek.unixy.pl
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/