Re: System clock runs too fast after 2.6.27 -> 2.6.28.1 upgrade

From: Ingo Molnar
Date: Sun Jan 25 2009 - 11:01:19 EST



* Florian Fainelli <florian.fainelli@xxxxxxxxxxxxx> wrote:

> Le Sunday 25 January 2009 16:03:49 Ingo Molnar, vous avez écrit :
> > * Florian Fainelli <florian.fainelli@xxxxxxxxxxxxx> wrote:
> > > Le Saturday 24 January 2009 10:14:04 Ingo Molnar, vous avez écrit :
> > > > * john stultz <johnstul@xxxxxxxxxx> wrote:
> > > > > On Fri, Jan 23, 2009 at 3:04 AM, Ingo Molnar <mingo@xxxxxxx> wrote:
> > > > > > * john stultz <johnstul@xxxxxxxxxx> wrote:
> > > > > >> I'd think this would ideally be more of a subarch in the config
> > > > > >> selection like the AMD Elan is, so folks know it really is not
> > > > > >> just a extra-support feature and in fact limits what hardware you
> > > > > >> can use the resulting kernel on.
> > > > > >
> > > > > > a better solution is that if RDC is set [it is unset by default] we
> > > > > > should turn PIT_TICK_RATE into a variable, defaulting it to
> > > > > > 1193182. If a real RDC or ELAN system is running, that variable is
> > > > > > changed during early bootup, in the init functions for those
> > > > > > platforms.
> > > > >
> > > > > Took a quick look at this, and I don't see any detection code for
> > > > > either RDC. The X86_ELAN config also has no conditionals, but maybe
> > > > > the elan cpufreq code can help here.
> > > >
> > > > i'd suggest to just remove the #ifdef for now (it's causing problems)
> > > > and add the variable - we can add the quirks for those two platforms
> > > > later on, separately from your patch(es).
> > >
> > > Fine with me. Ingo, is there any infrastructure yet to get an early
> > > quirk set the PIT tick rate accordingly ?
> >
> > Not yet but it should be easy - do you have the time to implement it?
>
> Not until a week, sorry.

ok - i've done the interim patch below. Please send a quirk patch for
RDC's non-standard PIT frequency.

Ingo

------------------->