Re: [PATCH 1/1] mmc: add MODALIAS linkage for MMC/SD devices

From: Kay Sievers
Date: Sat Jan 24 2009 - 18:51:19 EST


On Sat, Jan 24, 2009 at 18:56, Pierre Ossman <drzeus-mmc@xxxxxxxxx> wrote:
> On Thu, 15 Jan 2009 15:00:03 +0000
> Andy Whitcroft <apw@xxxxxxxxxxxxx> wrote:
>
>>
>> Would it make more sense to simply use mmc: with no data as the MODALIAS
>> tag here. And make mmc-block have mmc:* as an alias. That way the
>> actual (useless) numeric data is not exposed but we still will load the
>> mmc-block module for everything exactly as we do with the udev rule.
>> This should still make things work from a distro point of view and not
>> expose anything which might then get relied on. If we do it so extra
>> data can still be added later we won't prevent sane data being exposed
>> should we ever have any.
>>
>> If you are happier with that I can re-spin the patches that way?
>>
>
> Well, as long as we're on the track of temporary hack, we might as well
> just export "mmc_block" as the modalias. Or would there be any
> side-effects to that?

The common format is to prefix with "<subsystem>:". Something like
"mmc:block" sounds fine to me.

Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/