Re: [PATCH] ricoh_mmc: Use suspend_late/resume_early

From: Rafael J. Wysocki
Date: Sat Jan 24 2009 - 15:55:32 EST


On Saturday 24 January 2009, Philip Langdale wrote:
> Pierre Ossman wrote:
> > On Sun, 18 Jan 2009 14:11:20 -0500 (EST)
> > philipl@xxxxxxxxx wrote:
> >
> >> If ricoh_mmc suspends before sdhci_pci, it will pull the card
> >> out from under the controller, which could leave the system in
> >> a very confused state.
> >>
> >> Using suspend_late/resume_early ensures that sdhci_pci suspends first
> >> and resumes second.
> >>
> >> Signed-off-by: Philip Langdale <philipl@xxxxxxxxx>
> >> ---
> >
> > What's the plan here? Apply for .29?
>
> That's what I'd recommend - we are seeing reports of problems that
> would be fixed by this.
>
> eg: http://lkml.org/lkml/2009/1/21/241

Agreed.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/