Re: [PATCH] autofs4: turn ->oz_pgrp into "struct pid *"

From: Ian Kent
Date: Fri Jan 23 2009 - 04:13:33 EST

On Fri, 2009-01-23 at 09:06 +0100, Oleg Nesterov wrote:
> On 01/23, Ian Kent wrote:
> >
> > On Sun, 2009-01-18 at 08:34 +0100, Oleg Nesterov wrote:
> > >
> > > I guess autofs4_show_options()->pid_vnr() is not exactly right, but hopefully
> > > not worse than the current code.
> >
> > But shouldn't pid_vnr(sbi->oz_pgrp) report the pid as seen in the
> > namespace of the calling process? In which case the only problem would
> > be listing the mount table from a subordinate namespace that cannot see
> > the process which did the mount, assuming fs namespace is not linked in
> > some strict way to pid namespace, this could give an odd result. What
> > might happen in this case Oleg?
> Yes, nothing bad can happen. pid_vnr() just returns 0 if the calling
> process can't see the namespace.
> But I was worried about the case when, say, we are looking at
> /subnamespace_root_mount/proc/mounts.
> In that case pid_vnr() will report the pid_t in the global namespace,
> this differs from the case when this file is read by its own namespace
> as /proc/mounts.
> I do not know whether this is right or not, though.

Right, but mostly a source of confusion than anything else as things
will still function OK. Not sure how to deal with that!


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at