Re: [PATCH 2/7] memcg : use CSS ID in memcg

From: Daisuke Nishimura
Date: Fri Jan 23 2009 - 03:13:18 EST


> > +static s64 mem_cgroup_local_usage(struct mem_cgroup_stat *stat)
> > +{
> > + s64 ret;
> > +
> It would be better to initialize it to 0.
>
> > + ret = mem_cgroup_read_stat(stat, MEM_CGROUP_STAT_CACHE);
> > + ret += mem_cgroup_read_stat(stat, MEM_CGROUP_STAT_RSS);
> > + return ret;
> > +}
> > +
Ah, ret is initialized by mem_cgroup_read_stat...

please ignore the above comment.


Thanks,
Daisuke Nishimura.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/