Re: [Patch] Btrfs: use BTRFS_VOL_NAME_MAX for structbtrfs_ioctl_vol_args

From: AmÃrico Wang
Date: Thu Jan 22 2009 - 11:11:26 EST

On Wed, Jan 21, 2009 at 10:04:08AM -0500, Chris Mason wrote:
>On Mon, 2009-01-19 at 21:12 +0800, AmÃrico Wang wrote:
>> On Mon, Jan 19, 2009 at 08:03:37AM -0500, Josef Bacik wrote:
>> >On Mon, Jan 19, 2009 at 08:57:32PM +0800, AmÃrico Wang wrote:
>> >>
>> >> I found userspace tool, btrfsctl, uses BTRFS_VOL_NAME_MAX, and
>> >> it also looks that this one is more proper.
>> >>
>> >> Kill BTRFS_PATH_NAME_MAX since no one will use it.
>> >>
>> >
>> >Nope, BTRFS_PATH_NAME_MAX is specifically used for the ioctl stuff, makes the
>> >arguments 4k aligned, this patch is incorrect. Thanks,
>> Ok, then what is BTRFS_VOL_NAME_MAX? :)
>Right now it is only used in the progs. The disk format doesn't really
>have a max there, it is just to keep names usable. But, we should add a
>check in the kernel ioctl side, are you interested in sending a patch
>for it?

Yup, I will do.


"Against stupidity, the gods themselves, contend in vain."

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at