Re: [PATCH] coda: alloc_upcall: s/task_pgrp_nr/task_pgrp_vnr/

From: Oleg Nesterov
Date: Wed Jan 21 2009 - 08:47:22 EST

On 01/21, Jan Harkes wrote:
> On Sun, Jan 18, 2009 at 08:34:53AM +0100, Oleg Nesterov wrote:
> > Needs an ack from maintaner, I do not know where coda_in_hdr->pgid is used.
> It is used to uniquely identify a process and any of it children during
> conflict resolution.
> When a conflict is detected, all accesses to the inconsistent object are
> blocked. A special resolver process is forked off by the cache manager
> and this is run in a new process group and only accesses from processes
> in this group are allowed. The resolver process (or any of it's children)
> compare the conflicting replicas, and ideally resolve the inconsistency
> after which normal accesses are unblocked.
> So yes this should not a per namespace thing, but also not a process
> specific pid, the resolver forks off different helper processes
> depending on the type of files that are involved in the conflict, i.e.
> mbox files require different merge strategy compared to opendocument
> files.

OK, thanks, please ignore this patch then.

> I'm not sure what you are trying to do.

Please look at

And I'd like to kill task_pgrp_nr(). Can't alloc_upcall() use
task_pgrp_nr_ns(current, &init_pid_ns) instead? This is equivalent.

But if this pid_t is used in the user-space to identify the process,
then I think Eric is right.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at