Re: btrfs: readdir problem workaround for 32-bit off_t

From: Chris Mason
Date: Sat Jan 17 2009 - 16:27:51 EST


On Sat, 2009-01-17 at 20:39 +0100, Jan Engelhardt wrote:
> Hi,
>
>
>
> I am seeing abnormal kernel<->userland interaction for range-exceeding
> offsets during readdir.
> A suggested patch for btrfs is below, but I think there could also
> be involvement of (read: a bug in) Glibc.
> Would the copied parties please have a look, as it may spans both glibc
> and btrfs.
>

Thanks for looking into this.

Your patch is how the code originally looked, but it can lead to loops
in buggy userland (a git bug hit this). My plan was to mask off the
limit the same way XFS now does.

This is a btrfs bug, not glibc.

-chris


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/