Re: [PULL}: latest tip/cpus4096 changes

[Ingo Molnar]

* Mike Travis <travis@xxxxxxx> wrote:

> Hi Ingo,
> 
> I did notice that the versions all came up the same, and that the checks 
> were very specific.  I was trying to be as transparent and unintrusive 
> as possible.  Since there's so few calls, I though this was a good 
> approach but apparently I was wrong.
> 
> I like the idea of collapsing the array down to one and checking to see 
> if all apic's have the same version, but is this really the case? Must 
> all apics be the same?

Could you please send a patch that doesnt change the code, only adds a 
'boot APIC version' kind of variable as an apic_version __read_mostly 
variable and does a WARN_ONCE() if that mismatches? We can then stick that 
into -tip and see whether it triggers.

The max array size is ~128K, right? So if the WARN_ONCE() does not 
trigger, we can just drop the array and use the central apic_version 
variable ...

And even if it _does_ trigger, the version incompatibilities between APIC 
protocols are very rare. They only happen across wildly different CPU 
architectures like when going from very old external apics to integrated 
apics, or going from apics to x-apics. We wont see any mixing across those 
boundaries.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/