Re: [PATCH 2.6.29-rc1-git4] mfd: da9030 usb charge pump support within mfd driver.

[Mike Rapoport]

Eric Miao wrote:
> On Thu, Jan 15, 2009 at 2:16 AM, Jonathan Cameron <jic23@xxxxxxxxx> wrote:
>> From: Jonathan Cameron <jic23@xxxxxxxxx>
>>
>> Add support for changing the mode of the da9030 usb charge pump
>>
> 
> Well, if it is totally USB charger related, I'd suggest to move this into
> the dedicated driver. This mfd/da903x.c serves as a common code
> base for all sub-peripherals.

It's not exactly related to the charger, it's rather related to the USB voltage
supplied to USB devices attached to PXA OHCI.
Indeed the mfd/da903x.c serves as a common core for sub-peripherals, but IMHO
adding a subdevice driver because of single method doesn't worth the overhead.
I'm for the solution Jonathan proposes.


-- 
Sincerely yours,
Mike.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/