Re: [linux-pm] [PATCH] resume: wait for device probing to finish

From: Nigel Cunningham
Date: Wed Jan 14 2009 - 20:44:28 EST


Hi Rafael etc.

On Thu, 2009-01-15 at 00:39 +0100, Rafael J. Wysocki wrote:

[...]

> /**
> + * wait_for_device_probe
> + * Wait for device probing to be completed.
> + *
> + * Note: this function polls at 100 msec intervals.
> + */
> +int wait_for_device_probe(void)
> +{
> + /* wait for the known devices to complete their probing */
> + while (driver_probe_done() != 0)
> + msleep(100);
> + async_synchronize_full();
> + return 0;
> +}
> +

Am I missing something? I can't see why you're polling instead of using
probe_waitqueue.

Regards,

Nigel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/