Re: [PATCH 0/9] oprofile: implement support of samples with variabledata size

From: Maynard Johnson
Date: Wed Jan 14 2009 - 16:53:46 EST


Robert Richter wrote:
> This patch series implements support of samples with variable data
> size. Current implementation has a fixed sample size of 2 unsigned
> longs. This makes it hard to implement use cases with a different
> sample size (AMD IBS or power pc cell) since buffer locking is
> required or samples my become incomplete. The internal cpu buffer
> usage has been changed now and allows the attachment of data with
> varable length to samples.
>
> There are patches that also change the current ibs implementation. In
> the end the ibs implentation could be removed from the general
> oprofile code to model specific code. An API is available that
> provides generic functions to use variable sample sizes.
>
> The patches are also available here:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git oprofile-for-tip
This patch set looks fine. Nice work! I still need to test on a couple of platforms, though. Feel free to bug me if I don't get back to you with results within a week or so.

-Maynard
>
> -Robert
>
>
>
>
> ------------------------------------------------------------------------------
> Check out the new SourceForge.net Marketplace.
> It is the best place to buy or sell services for
> just about anything Open Source.
> http://p.sf.net/sfu/Xq1LFB
> _______________________________________________
> oprofile-list mailing list
> oprofile-list@xxxxxxxxxxxxxxxxxxxxx
> https://lists.sourceforge.net/lists/listinfo/oprofile-list

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/