Re: [PATCH v3 1/2] sched: de CPP-ify the scheduler code

[Steven Rostedt]

On Wed, 14 Jan 2009, Gregory Haskins wrote:

>  
> -#define enqueue_pushable_task(rq, p) do { } while (0)
> -#define dequeue_pushable_task(rq, p) do { } while (0)
> +static inline
> +void enqueue_pushable_task(struct rq *rq, struct task_struct *p) {}
> +static inline
> +void dequeue_pushable_task(struct rq *rq, struct task_struct *p) {}

Wouldn't the above look better as:

static inline void
enqueue_pushable_task(struct rq *rq, struct task_struct *p)
{
}
static inline void
dequeue_pushable_task(struct rq *rq, struct task_struct *p)
{
}


-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/