Re: [PATCH] softlock: fix false panic which can occur ifsoftlockup_thresh is reduced

From: Ingo Molnar
Date: Wed Jan 14 2009 - 05:48:58 EST



* Mandeep Singh Baines <msb@xxxxxxxxxx> wrote:

> At run-time, if softlockup_thresh is changed to a much lower value,
> touch_timestamp is likely to be much older than the new softlock_thresh.
>
> This will cause a false softlockup to be detected. If softlockup_panic
> is enabled, the system will panic.
>
> The fix is to touch all watchdogs before changing softlockup_thresh.
>
> Signed-off-by: Mandeep Singh Baines <msb@xxxxxxxxxx>
> ---
> include/linux/sched.h | 3 +++
> kernel/softlockup.c | 9 +++++++++
> kernel/sysctl.c | 2 +-
> 3 files changed, 13 insertions(+), 1 deletions(-)

applied to tip/core/urgent, thanks!

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/