Re: [PATCH] tcp: splice as many packets as possible at once

From: David Miller
Date: Tue Jan 13 2009 - 23:25:45 EST


From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Wed, 14 Jan 2009 14:51:24 +1100

> Unfortunately this won't work, not even for network destinations.
>
> The reason is that this gets called as soon as the destination's
> splice hook returns, for networking that means when sendpage returns.
>
> So by that time we'll still be left with just a page reference
> on a page where the slab memory may already have been freed.
>
> To make this work we need to get the destination's splice hooks
> to acquire this reference.

Yes I realized this after your earlier posting today.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/