Re: [PATCH] ext3: wait on all pending commits in ext3_sync_fs

From: Theodore Tso
Date: Tue Jan 13 2009 - 23:24:24 EST


On Tue, Jan 13, 2009 at 04:14:11PM -0600, Eric Sandeen wrote:
>
> This looks sane to me, and it does fix the below testcase.
>
> Care to formally propose it?

Can we confirm what is being proposed? From following this thread, I
think what folks are suggesting is:

1) Revert the current "ext3/4: wait on all pending ocmmits in ext3/4_sync_fs"

2) Apply Jan's patch "jbd[2]: Fix return value of journal_start_commit()"

3) Also apply Jan's patch "jbd2: Skip commit of a transaction without
any buffers" since it appears to be a good optimization (although it's
not clear it would happen once we revert (1), above.

- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/