checkpatch confused by pre-existing #endif

From: Pavel Roskin
Date: Tue Jan 13 2009 - 16:57:57 EST


Hello!

This patch confuses checkpatch.pl from Linux 2.6.29-rc1:

====================
--- foo.h.old 2009-01-13 16:48:22.000000000 -0500
+++ foo.h 2009-01-13 16:48:18.000000000 -0500
@@ -3,4 +3,8 @@



+#ifdef FOOBAR
+#define foo
+#endif
+
#endif /* FOO_H */
====================

$ scripts/checkpatch.pl foo.diff
Can't use an undefined value as an ARRAY reference at
scripts/checkpatch.pl line 453.

Apparently, the last #endif causes some data to be popped from the stack
for preprocessor directives. However, the corresponding #ifdef is
outside the patch, so this fails.

--
Regards,
Pavel Roskin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/