Re: [PATCH -tip] x86: headers - include linux/types.h instead ofasm/types.h

[Cyrill Gorcunov]

[Cyrill Gorcunov - Tue, Jan 13, 2009 at 03:09:05PM +0300]
| Impact: cleanup
| 
| 'make headers_check' warns that linux/types.h is
| preferred over asm/types.h. So be it.
| 
| Signed-off-by: Cyrill Gorcunov <gorcunov@xxxxxxxxxx>
| CC: Jaswinder Singh Rajput <jaswinderrajput@xxxxxxxxx>
| CC: Sam Ravnborg <sam@xxxxxxxxxxxx>
| CC: Harvey Harrison <harvey.harrison@xxxxxxxxx>
| ---
| 
|  arch/x86/include/asm/e820.h       |    2 ++
|  arch/x86/include/asm/kvm.h        |    2 +-
|  arch/x86/include/asm/mce.h        |    2 +-
|  arch/x86/include/asm/mtrr.h       |    1 +
|  arch/x86/include/asm/ptrace-abi.h |    2 +-
|  arch/x86/include/asm/sigcontext.h |    2 +-
|  arch/x86/include/asm/swab.h       |    2 +-
|  7 files changed, 8 insertions(+), 5 deletions(-)
|
...

well... on the other hand I'm not sure if it's really
a good idea to include linux/types.h where we need only
__u[8,16] and so on definitions.

Ingo, don't apply this patch please -- have to check
for other ways.
 
		- Cyrill -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/