Re: Build error on latest git

From: Petr Titera
Date: Sun Jan 11 2009 - 07:04:58 EST


Going through source it seems to me (still building) that it is caused by including asm/smp.h only if build with CONFIG_SMP. This patch seems to fix this

diff --git a/include/linux/smp.h b/include/linux/smp.h
index b824669..fd51bb9 100644
--- a/include/linux/smp.h
+++ b/include/linux/smp.h
@@ -11,6 +11,8 @@
#include <linux/list.h>
#include <linux/cpumask.h>

+#include <asm/smp.h>
+
extern void cpu_idle(void);

struct call_single_data {
@@ -30,7 +32,6 @@ extern unsigned int total_cpus;
#include <linux/kernel.h>
#include <linux/compiler.h>
#include <linux/thread_info.h>
-#include <asm/smp.h>

/*
* main cross-CPU interfaces, handles INIT, TLB flush, STOP, etc.


Petr Titera napsal(a):
Hello,

I'm getting this build error in arch/x86/kernel/mpparse.c using latest git:

arch/x86/kernel/mpparse.c: In function âMP_processor_infoâ:
arch/x86/kernel/mpparse.c:57: error: âdisabled_cpusâ undeclared (first use in this function)
arch/x86/kernel/mpparse.c:57: error: (Each undeclared identifier is reported only once
arch/x86/kernel/mpparse.c:57: error: for each function it appears in.)
arch/x86/kernel/mpparse.c: In function âMP_bus_infoâ:
arch/x86/kernel/mpparse.c:85: error: implicit declaration of function âapic_printkâ
arch/x86/kernel/mpparse.c:85: error: âAPIC_VERBOSEâ undeclared (first use in this function)
arch/x86/kernel/mpparse.c: In function âprint_MP_intsrc_infoâ:
arch/x86/kernel/mpparse.c:156: error: âAPIC_VERBOSEâ undeclared (first use in this function)
arch/x86/kernel/mpparse.c: In function âprint_mp_irq_infoâ:
arch/x86/kernel/mpparse.c:164: error: âAPIC_VERBOSEâ undeclared (first use in this function)
arch/x86/kernel/mpparse.c: In function âMP_lintsrc_infoâ:
arch/x86/kernel/mpparse.c:236: error: âAPIC_VERBOSEâ undeclared (first use in this function)
arch/x86/kernel/mpparse.c: In function âsmp_read_mpcâ:
arch/x86/kernel/mpparse.c:395: error: ânum_processorsâ undeclared (first use in this function)
arch/x86/kernel/mpparse.c: In function â__get_smp_configâ:
arch/x86/kernel/mpparse.c:670: error: ânum_processorsâ undeclared (first use in this function)
arch/x86/kernel/mpparse.c: In function âsmp_scan_configâ:
arch/x86/kernel/mpparse.c:692: error: âAPIC_VERBOSEâ undeclared (first use in this function)
make[1]: *** [arch/x86/kernel/mpparse.o] Error 1
make: *** [arch/x86/kernel] Error 2

Petr Titera

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/