Re: [PATCH 1/2] swiotlb: range_needs_mapping should take aphysical address.

[FUJITA Tomonori]

On Fri,  9 Jan 2009 18:32:09 +0000
Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:

> The swiotlb_arch_range_needs_mapping() hook should take a physical
> address rather than a virtual address in order to support highmem pages.
> 
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> ---
>  arch/x86/kernel/pci-swiotlb_64.c |    2 +-
>  include/linux/swiotlb.h          |    2 +-
>  lib/swiotlb.c                    |   10 +++++-----
>  3 files changed, 7 insertions(+), 7 deletions(-)

Yeah, using a cpu address here doesn't make sense. I wondered what you
were trying with a cpu address when reading your original patch.

Might be more clean to unify address_needs_mapping and
range_needs_mapping. I guess that I need to see what Xen wants to do
with this though.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/