Re: [PATCH 1/4] irq: change references from NR_IRQS to nr_irqs

From: Ingo Molnar
Date: Sat Jan 10 2009 - 17:45:57 EST



* Mike Travis <travis@xxxxxxx> wrote:

> Impact: preparation, cleanup

s/Impact: preparation, cleanup/Impact: preparation, cleanup, add printk

> @@ -160,9 +162,9 @@ struct irq_desc *irq_to_desc_alloc_cpu(u
> unsigned long flags;
> int node;
>
> - if (irq >= NR_IRQS) {
> - printk(KERN_WARNING "irq >= NR_IRQS in irq_to_desc_alloc: %d %d\n",
> - irq, NR_IRQS);
> + if (irq >= nr_irqs) {
> + printk(KERN_WARNING "irq >= nr_irqs in irq_to_desc_alloc: %d %d\n",
> + irq, nr_irqs);
> WARN_ON(1);
> return NULL;

While at it, could you please also convert this to a WARN() construct
instead? (in a separate commit)

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/