Re: Regulator consumer and i2c device interaction.

From: Jonathan Cameron
Date: Sat Jan 10 2009 - 13:46:50 EST


Jonathan Cameron wrote:
> Dear All,
>
> Currently regulator consumers are registered and identified via a pointer to the relevant
> device:
>
> e.g. via a regulator consumer supply structure:
> static struct regulator_consumer_supply imote2_sensor_3_con[] = {
> {
> .dev = &sht15.dev,
> .supply = "vcc",
> },
> };
>
> static struct regulator_init_data imote2_ldo_init_data[] = {{
> {
> .constraints = {
> .name = "vcc_sensor_3",
> .min_uV = 2800000,
> .max_uV = 3000000,
> .valid_ops_mask = REGULATOR_CHANGE_VOLTAGE,
> },
> .num_consumer_supplies = ARRAY_SIZE(imote2_sensor_3_con),
> .consumer_supplies = imote2_sensor_3_con,
> },
> };
>
> and relevant association with a regulator driver.
>
> Now in the case of i2c devices, the struct device pointer is created
> somewhat later and isn't readily available.
>
> I think the struct device pointer is only used as device instance specific
> token in the regulator framework. If so is there any reason it can't be
> relaxed to a void * thus allowing something else to be used in i2c drivers?
>
> If so what could actually be used? Unfortunately all the data elements
> of i2c_board_info are coppied out (rather than a pointer to the original
> structure being used) so that's not currently available. I guess it could
> be made so at the cost of a single pointer in each i2c_client structure.
>
Oops, that won't work as typically these are specified __initdata .
Any suggestions for alternatives?
> So the question is how would people prefer to do this?
>
> Thanks,
>
> --
> Jonathan Cameron
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/