Re: [PATCH] cpumask fallout: Initialize irq_default_affinity earlier.

From: David Daney
Date: Thu Jan 08 2009 - 15:50:42 EST


Linus Torvalds wrote:
[...]
In fact, I think it already is a no-op in the UP case, and you can literally just do

static inline void __init init_irq_default_affinity(void)
{
alloc_cpumask_var(&irq_default_affinity, GFP_KERNEL);
cpumask_setall(irq_default_affinity);
}

and be done with it. I think it should all compile away to nothing if CONFIG_SMP isn't set.

The 'inline' seems gratuitous to me. Since it is static GCC should do the Right Thing. However since you suggested it, I am testing it that way.

David Daney
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/