Re: [PATCH] ring_buffer: fix ring_buffer_event_length()

[Ingo Molnar]

* Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On Wed, 7 Jan 2009, Andrew Morton wrote:
> 
> > On Wed, 7 Jan 2009 23:58:39 -0500 (EST) Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> > 
> > >  kernel/trace/ring_buffer.c |    8 +++++++-
> > 
> > <looks>
> > 
> > heavens, what a lot of inlining.  Looks like something from 1997 :)
> > 
> > Prove me wrong!
> 
> I'm working on it ;-)

i really think that inlines in .c code are uninteresting. They are 
basically inserted randomly when a function starts out 'looking simple' - 
then are forgotten about when the function grows a bit.

They have some very mild documentation value ('look, this function is 
supposed to be simple'), but otherwise it just increases review noise. And 
latest GCC seems pretty ambivalent to their presence - so they dont help 
nor hurt in any direction.

So i think we can afford to enter the year 2009 and can stop bothering 
about [.c file] inlines ;-)

[ The only interesting inlines are the __always_inline instances - that's 
  where we _must_ have inlining for some subtle reason. But those should 
  almost never be used in .c code. ]

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/