Re: [Regression] hald segfaults at startup on Toshiba Portege R500x86_64 (bisected)

[Pierre Ossman]

On Thu, 8 Jan 2009 08:27:02 +0100
"Rafael J. Wysocki" <rjw@xxxxxxx> wrote:

> Hi,
> 
> Unfortunately the following commit:
> 
> commit 35ff8554d12ecc80a46ea0d9bce34fe28733ff38
> Author: Ãric Piel <eric.piel@xxxxxxxxxxxxxxxx>
> Date:   Sat Nov 22 19:29:29 2008 +0100
> 
>     sdhci: activate led support also when module
> 
>     CONFIG_LEDS_CLASS is defined only if led-class is built-in, otherwise
>     when it is a module the option is called CONFIG_LEDS_CLASS_MODULE. Led
>     support should also be activated in this case.
> 
>     Signed-off-by: Eric Piel <eric.piel@xxxxxxxxxxxxxxxx>
>     Signed-off-by: Pierre Ossman <drzeus@xxxxxxxxx>
> 
> causes hald to segfault at startup (not always, but sufficiently often for
> bisection) on my Toshiba Portege R500 w/ x86_64 kernel/userland.
> 

I have trouble seeing a user space application crashing as a kernel
bug. Do you have a backtrace or strace of hald to see exactly where it
crashes?

> While it doesn't revert cleanly, I have applied the appended patch (which is
> a revert of the commit above) and hald doesn't segfault any more here.
> 

Is CONFIG_LEDS_CLASS defined in your config, or are you essentially
turning of the LED functionality?

Rgds
-- 
     -- Pierre Ossman

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.

Attachment: signature.asc
Description: PGP signature