Re: [PATCH -tip] x86: setup.c fix style problems

[Ingo Molnar]

* Jaswinder Singh Rajput <jaswinderlinux@xxxxxxxxx> wrote:

> On Sun, Jan 4, 2009 at 10:51 PM, Ingo Molnar <mingo@xxxxxxx> wrote:
> >
> > the x86-local declarations in smp.h should probably be moved into a
> > separate smp_x86.h file - to avoid such trouble.
> >
> 
> I think we do not need to make any new files only thing we need is to
> rearrange stuff between existing files.
> 
> Currently there is no such protocol, If we follow this logic then it
> will very easy for us to maintain things:
> 
> CONFIG_SMP -> asm/smp.h
> CONFIG_X86_LOCAL_APIC -> asm/apic.h
> CONFIG_X86_IO_APIC -> asm/io_apic.h

yep.

> And if you want then I will give strict instructions so that we will 
> never face these problems again, like :-
> 
> asm/smp.h:
> 
> #ifndef CONFIG_SMP
> #error "Including wrong file, why you need smp.h for Uniprocessor"
> #else
> ...
> #endif
> 
> Similarly for asm/apic.h and asm/io_apic.h

the smp.h change would work, agreed - but it's not really good for things 
like apic.h and io_apic.h - often apic.h is included to pick up init and 
various callback prototypes - which exist on !CONFIG_X96_IO_APIC too.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/