Re: [PATCH] [3/5] Mark complex bitops.h inlines as __always_inline

From: Ingo Molnar
Date: Tue Jan 06 2009 - 05:17:42 EST



* Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:

> Hugh Dickins noticed that older gcc versions when the kernel is built
> for code size didn't inline some of the bitops.

Older GCCs have a whole lot more problems than suboptimal inlining
decisions.

Your patch is wrong because it prevents a good compiler from doing the
right inlining decisions.

So why should i apply this?

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/