Re: [PATCH] mflash linux support

[Christoph Hellwig]

On Mon, Jan 05, 2009 at 11:13:21AM +0000, Alan Cox wrote:
> On Mon, 5 Jan 2009 04:33:46 +0200
> Heikki Orsila <shdl@xxxxxxxxxx> wrote:
> 
> > A few style issues:
> 
> How about starting by worrying about the code not pointless style
> complaints ?
> 
> >> > +	switch (cmd) {
> > > +	case HDIO_GETGEO:
> > 
> > 	if (cmd == HDIO_GETGEO) {
> 
> Especially when you are making pointless complaints about things that are
> generally done the way the original code is - and for good reason. It
> makes it far cleaner to add new ioctl support.

Or either of you could check what blkdev_ioctl() does with HDIO_GETGEO
and why this code doesn't even need to exist at all.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/