Re: early exception error

[Jiri Slaby]

On 01/05/2009 04:30 PM, Cyrill Gorcunov wrote:
> [Jiri Slaby - Mon, Jan 05, 2009 at 04:14:12PM +0100]
> | On 01/05/2009 04:01 PM, Cyrill Gorcunov wrote:
> | > [Jiri Slaby - Mon, Jan 05, 2009 at 03:51:26PM +0100]
> | > | On 01/05/2009 02:08 PM, Andi Kleen wrote:
> | > | > +#define EARLY_BUG_ON(x) do {} while(0)
> | > | 
> | > | Shouldn't be x referenced here?
> | > |
> | > 
> | > but for what?
> | 
> | I know, core devs are sane, but e.g. for reasons such as
> | 
> | {'a' is used here already}
> | EARLY_BUG_ON(!(a = readl(...)))
> | {use 'a' again}
> | 
> | to stay on the safe side.
> 
> I wouldn't populate this style Jiri. It become more complicated
> as it should to be, agreed?

No, I tend to disagree. Macros should evaluate argument(s) the same no matter
what is in .config.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/