Re: [patch] document ext3 a bit better

From: Theodore Tso
Date: Mon Jan 05 2009 - 09:57:59 EST


On Sun, Jan 04, 2009 at 11:34:33PM +0100, Pavel Machek wrote:
> @@ -14,6 +14,11 @@ Options
> When mounting an ext3 filesystem, the following option are accepted:
> (*) == default
>
> +ro Mount filesystem read only. Note that ext3 will replay
> + the journal (and thus write to the partition) even when
> + mounted "read only". "ro, noload" can be used to prevent
> + writes to the filesystem.

I'd sugest "ro,noload" since the spaces screw up the mount options
parsing both on the command-line and in /etc/fstab. So how about:

Using the mount options "ro,noload" can be used....

> @@ -95,6 +102,8 @@ debug Extra debugging information is s
> errors=remount-ro(*) Remount the filesystem read-only on an error.
> errors=continue Keep going on a filesystem error.
> errors=panic Panic and halt the machine if an error occurs.
> + (Note that default is overriden by superblock
> + setting on most systems).

The default is always specified by the superblock setting. So users
will probably find it easier to understand if we remove the "(*)" and
to add the explanatory comment:

(These mount options override the errors behavior
specified in the superblock, which can be configured
using tune2fs)

Pavel, thanks for working on improving the documentation; with these
fixes,

Signed-off-by: "Theodore Ts'o" <tytso@xxxxxxx>

- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/