Re: [PATCH -tip] x86: setup.c fix style problems

From: Ingo Molnar
Date: Mon Jan 05 2009 - 08:50:38 EST



* Jaswinder Singh Rajput <jaswinderlinux@xxxxxxxxx> wrote:

> On Mon, Jan 5, 2009 at 6:45 PM, Ingo Molnar <mingo@xxxxxxx> wrote:
> >
> > * Jaswinder Singh Rajput <jaswinder@xxxxxxxxxxxxx> wrote:
> >
> >> On Sun, 2009-01-04 at 21:34 +0100, Ingo Molnar wrote:
> >> > yeah - i mentioned it to you before that there are such cases.
> >> >
> >>
> >> OK, so here is new patch excluding smp.h:
> >
> > Could you please instead fix the smp.h assumption so that we dont hit this
> > in the future? Then we can apply your original patch.
>
> Sure, I will do it.
>
> > [ Do you need the
> > specific .config that hits this? Can dig it out if necessary. ]
>
> If you provide me that .config file then it will be very helpful for
> cross-checking.

hm, cannot find it - there's been too many other bugs in that timeframe so
i'd have to try a dozen configs to find out which one it was.

It's not a big problem i think: i'd suggest you fix the problem pinpointed
by the build error i sent to you - and if anything else happens with newer
patches i'll send you a full config for those problems. This area is thick
include file spaghetti that will need a few iterations to sort out.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/