Re: [PATCH V3 12/17] Squashfs: header files

[Pekka Enberg]

Hi Phillip,

On Mon, Jan 5, 2009 at 1:08 PM, Phillip Lougher
<phillip@xxxxxxxxxxxxxxxxxxx> wrote:
> +#define TRACE(s, args...)      pr_debug("SQUASHFS: "s, ## args)

You've probably heard this before but silly "tracing" such as:

    TRACE("Entered squashfs_fill_superblock\n");

should really be removed from the filesystem code.

> +#define ERROR(s, args...)      pr_err("SQUASHFS error: "s, ## args)
> +
> +#define WARNING(s, args...)    pr_warning("SQUASHFS: "s, ## args)

I think you're supposed to #define pr_fmt() in your header instead of
adding wrappers like these.

                        Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/