Re: [PATCH] headers_check.pl: disallow extern's

From: Mike Frysinger
Date: Fri Jan 02 2009 - 20:20:55 EST


On Friday 02 January 2009 19:09:57 Arnd Bergmann wrote:
> On Saturday 03 January 2009, Arjan van de Ven wrote:
> > in addition... what business does the kernel have to provide function
> > prototypes to userspace, other than the system call prototypes?
>
> This is the point I raised in my initial comment: we should warn about
> all of them if possible. Note that the syscalls.h file is not even
> exported. I can't think of a single case where a function protoype
> should be exported from the kernel to user space.

right, and unless people someone can come up with some magic perl code to
detect function prototypes, i suggest we start adding extern keywords ...
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.