Re: tip - Solution of ath9k: turn off temporarily(66b5c4a2c638b5a69d3e41abe4a2bae55035a92e)

From: Ingo Molnar
Date: Fri Jan 02 2009 - 14:58:32 EST



* H. Peter Anvin <hpa@xxxxxxxxxx> wrote:

> Jaswinder Singh Rajput wrote:
> >>
> >> diff --git a/drivers/net/wireless/ath9k/Kconfig b/drivers/net/wireless/ath9k/Kconfig
> >> index c43bd32..b849a45 100644
> >> --- a/drivers/net/wireless/ath9k/Kconfig
> >> +++ b/drivers/net/wireless/ath9k/Kconfig
> >> @@ -1,6 +1,8 @@
> >> config ATH9K
> >> tristate "Atheros 802.11n wireless cards support"
> >> depends on PCI && MAC80211 && WLAN_80211
> >> + # build failures
> >> + depends on 0
> >> select MAC80211_LEDS
> >> select LEDS_CLASS
> >> select NEW_LEDS
> >>
> >
>
> I thought the proper way to do this was "depends on BROKEN"...

this was just a temporary hack to work around a mild regression in -git
that i'm sure will be sorted out in short order (if it has not been
already).

CONFIG_BROKEN is a much different category: it blacklists ridiculously
stale or mortally broken features/drivers, as a last warning before they
get removed for good. I dont use it in such temporary, not-for-upstream
testing hacks (even though the end result is obviously the same as
'depends on 0') - i didnt even have time to properly report the build
breakage.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/