Re: [PATCH] x86: cpuid.c fix style problems

From: Ingo Molnar
Date: Fri Jan 02 2009 - 13:58:57 EST



* Pekka Enberg <penberg@xxxxxxxxxxxxxx> wrote:

> On Wed, Dec 31, 2008 at 12:59 PM, Jaswinder Singh Rajput
> <jaswinder@xxxxxxxxxxxxx> wrote:
> > cpu = iminor(file->f_path.dentry->d_inode);
> > - if (cpu >= NR_CPUS || !cpu_online(cpu)) {
> > + if (cpu >= num_possible_cpus() || !cpu_online(cpu)) {
>
> How come you didn't convert the first part of the expression to use
> cpu_possible()?

i skipped this bit btw., as it got mooted by the cleanups in the cpumask
and cpus4096 trees.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/